[processor/tailsampling] Support hot sampling policy loading #37014
+198
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Porter <[email protected]>
|
Will add that changelog entry. |
Signed-off-by: Sean Porter <[email protected]>
portertech
commented
Jan 3, 2025
| initialDecisions := make([]sampling.Decision, lenPolicies) | ||
| for i := 0; i < lenPolicies; i++ { | ||
| initialDecisions[i] = sampling.Pending | ||
| } |
There was a problem hiding this comment.
I discovered this little chunk of no-op code, leftover from a decision refactor.
mwear
reviewed
Jan 6, 2025
Co-authored-by: Matthew Wear <[email protected]>
Co-authored-by: Matthew Wear <[email protected]>
Signed-off-by: Sean Porter <[email protected]>
|
@mwear thank you for the review, applied your suggested changes 👍 |
mwear
approved these changes
Jan 6, 2025
jpkrohling
approved these changes
Jan 7, 2025
| } | ||
|
|
||
| func (tsp *tailSamplingSpanProcessor) SetSamplingPolicy(cfgs []PolicyCfg) { | ||
| tsp.logger.Debug("Setting pending sampling policy", zap.Int("pending.len", len(cfgs))) |
There was a problem hiding this comment.
For a follow-up PR: it would be useful to have a counter, stating how many times the sampling policy has been set.
| } | ||
| tsp.SetSamplingPolicy(cfgs) | ||
|
|
||
| assert.Len(t, tsp.policies, 2) |
There was a problem hiding this comment.
this confused me for a little moment, as I was expecting "3" here -- perhaps add another assertion, with Len(t, tsp.pendingPolicy, 3), to highlight that the cfgs has been accepted by SetSamplingPolicy?
|
I'm merging, the comments I left can be addressed on a follow-up PR. |
jpkrohling
changed the title
AkhigbeEromo
pushed a commit
to sematext/opentelemetry-collector-contrib
that referenced
this pull request
Jan 13, 2025
…lemetry#37014) #### Description Adding a feature. This pull-request adds support for hot sampling policy loading to the tail sampling processor. This allows the collector (or another service using the processor) to dynamically update tail sampling policy without needing to restart the processor (or the entire collector). This greatly minimizes the impact of sampling policy modifications on pipeline availability and processing. Changes to policy are safely applied on the next tick loop. A collector (and/or other service) could use OpAMP to remotely manage sampling policy with little to no negative impact on pipeline availability and performance. This is what the https://tailctrl.io/ agent did. #### Usage Currently need to define a custom interface in order to set sampling policy. ``` go type SamplingProcessor interface { processor.Traces SetSamplingPolicy(cfgs []tailsamplingprocessor.PolicyCfg) } factory := tailsamplingprocessor.NewFactory() tsp, _ := factory.CreateTraces() sp = tsp.(SamplingProcessor) sp.SetSamplingPolicy(cfgs) ``` #### Testing Added a test to ensure changes to policy are loaded. Using the changes in a private project. --------- Signed-off-by: Sean Porter <[email protected]> Co-authored-by: Matthew Wear <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a feature. This pull-request adds support for hot sampling policy loading to the tail sampling processor. This allows the collector (or another service using the processor) to dynamically update tail sampling policy without needing to restart the processor (or the entire collector). This greatly minimizes the impact of sampling policy modifications on pipeline availability and processing. Changes to policy are safely applied on the next tick loop.
A collector (and/or other service) could use OpAMP to remotely manage sampling policy with little to no negative impact on pipeline availability and performance. This is what the https://tailctrl.io/ agent did.
Usage
Currently need to define a custom interface in order to set sampling policy.
Testing
Added a test to ensure changes to policy are loaded. Using the changes in a private project.