Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] add ValueExpression to support extraction of values from the signal context #36883

Merged

Conversation

bacherfl
Copy link
Contributor

@bacherfl bacherfl commented Dec 18, 2024

Description

This PR adds a new ParseValueExpression method to the OTTL parser which allows users of this package to extract data from the context using OTTL

Link to tracking issue

Fixes #35621

Testing

Added unit and e2e tests

Documentation

Added godoc comments for the added methods and types

Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
@bacherfl bacherfl changed the title Feat/35621/ottl expression evaluation [pkg/ottl] add ValueExpression to support extraction of values from the signal context Dec 18, 2024
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good to me.

.chloggen/ottl-value-expression.yaml Outdated Show resolved Hide resolved
pkg/ottl/parser.go Outdated Show resolved Hide resolved
.chloggen/ottl-value-expression.yaml Outdated Show resolved Hide resolved
.chloggen/ottl-value-expression.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Jan 4, 2025

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jan 4, 2025
@bacherfl bacherfl removed the Stale label Jan 7, 2025
@bacherfl bacherfl marked this pull request as ready for review January 7, 2025 08:54
@bacherfl bacherfl requested a review from a team as a code owner January 7, 2025 08:54
@evan-bradley evan-bradley requested a review from edmocosta January 9, 2025 15:00
pkg/ottl/parser.go Outdated Show resolved Hide resolved
@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Jan 9, 2025
Copy link
Contributor

@edmocosta edmocosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left a minor nitpick for your consideration.

pkg/ottl/parser_test.go Show resolved Hide resolved
@TylerHelmuth TylerHelmuth merged commit fce9e46 into open-telemetry:main Jan 14, 2025
163 checks passed
@github-actions github-actions bot added this to the next release milestone Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/ottl ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pkg/ottl] Support for data retrieval OTTL expressions
5 participants