Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/goccy/go-json from v0.10.3 to v0.10.4 #36807

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

toddtreece
Copy link
Contributor

Description

Updates github.com/goccy/go-json with fix from goccy/go-json#490

Additional details via #36765:

The github.com/goccy/go-json module contains an init() function which warms up a cache even if the module is never used. I believe this causes around 20 MB of memory per Collector instance. This is an issue for users who run many instances of the Collector. If you run hundreds of instances, 20 MB per instance adds up to a lot.

Currently, github.com/goccy/go-json seems to be used only by the Splunk HEC Exporter, Stanza, and OTTL. I suppose all other functionality doesn't need the cache.

There is a goccy/go-json#490 opened upstream to improve the cache so that it is loaded lazily - only if goccy/go-json is used.

Link to tracking issue

Fixes #36765

@mx-psi mx-psi added the ready to merge Code review completed; ready to merge by maintainers label Dec 12, 2024
@TylerHelmuth TylerHelmuth merged commit c5a662f into open-telemetry:main Dec 12, 2024
184 of 187 checks passed
@github-actions github-actions bot added this to the next release milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

goccy/go-json dependency causes unnecessary memory allocations
6 participants