googlemanagedprometheusexporter: add config option for cumulative normalization #36357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ridwanmsharif
requested review from
dashpole,
jsuereth and
a team
as code owners
github-actions
bot
added
the
exporter/googlemanagedprometheus
…malization This change will allow the configurer to set whether cumulative normalization should be set. The main benefit from this is so we can send the first point immediately as we see them. This will allow our serverless offering to unfork the exporter: https://github.com/GoogleCloudPlatform/run-gmp-sidecar/tree/main/collector/exporter/googlemanagedprometheusexporter Signed-off-by: Ridwan Sharif <[email protected]>
ridwanmsharif
force-pushed
the
ridwanmsharif/configure-cumulative-normalization
branch
from
a78c904 to
109bfc6
Compare
jsuereth
approved these changes
Nov 13, 2024
dashpole
added
the
ready to merge
ridwanmsharif
deleted the
ridwanmsharif/configure-cumulative-normalization
branch
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…malization (open-telemetry#36357) This change will allow the configurer to set whether cumulative normalization should be set. The main benefit from this is so we can send the first point immediately as we see them. This will allow our serverless offering to unfork the exporter: https://github.com/GoogleCloudPlatform/run-gmp-sidecar/tree/main/collector/exporter/googlemanagedprometheusexporter Signed-off-by: Ridwan Sharif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will allow the configurer to set whether cumulative normalization should be set. The main benefit from this is so we can send the first point immediately as we see them. This will allow our serverless offering to unfork the exporter:
https://github.com/GoogleCloudPlatform/run-gmp-sidecar/tree/main/collector/exporter/googlemanagedprometheusexporter