[cmd/opampsupervisor] feat: Support environment variable expansion in supervisor config #36270
+312
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… supervisor config
github-actions
bot
requested review from
atoulme,
evan-bradley and
tigrannajaryan
mrsillydog
force-pushed
the
feat/supervisor-config-env-variables
branch
from
a3a3dbc
to
fd1dadd
Compare
djaglowski
approved these changes
Dec 3, 2024
|
Generally looks good to me. Please resolve CI failures |
|
@djaglowski CI failures have been resolved so this should be good to go. |
evan-bradley
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows for the usage of environment variables within the OpAMP supervisor config.
Link to tracking issue
Fixes #36269
Testing