Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Translate k8s.*.name resource attributes in ECS mode #36233

Merged

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Nov 6, 2024

Description

In ECS mode:
Translate k8s.job.name, k8s.cronjob.name, k8s.statefulset.name, k8s.replicaset.name, k8s.daemonset.name, k8s.container.name to kubernetes.*.name. Translate k8s.cluster.name to orchestrator.cluster.name.

Link to tracking issue

Testing

Documentation

@carsonip carsonip marked this pull request as ready for review November 6, 2024 11:35
@carsonip carsonip requested a review from a team as a code owner November 6, 2024 11:35
@carsonip carsonip changed the title [exporter/elasticsearch] Translate k8s.*.name fields in ECS mode [exporter/elasticsearch] Translate k8s.*.name attributes to kubernetes.*.name in ECS mode Nov 6, 2024
@carsonip carsonip changed the title [exporter/elasticsearch] Translate k8s.*.name attributes to kubernetes.*.name in ECS mode [exporter/elasticsearch] Translate k8s.*.name resource attributes to kubernetes.*.name in ECS mode Nov 7, 2024
exporter/elasticsearchexporter/model.go Outdated Show resolved Hide resolved
exporter/elasticsearchexporter/model_test.go Outdated Show resolved Hide resolved
@carsonip carsonip changed the title [exporter/elasticsearch] Translate k8s.*.name resource attributes to kubernetes.*.name in ECS mode [exporter/elasticsearch] Translate k8s.*.name resource attributes in ECS mode Nov 7, 2024
@andrzej-stencel andrzej-stencel merged commit 8ec6180 into open-telemetry:main Nov 8, 2024
158 checks passed
@github-actions github-actions bot added this to the next release milestone Nov 8, 2024
pull bot pushed a commit to abaguas/opentelemetry-collector-contrib that referenced this pull request Nov 8, 2024
…n ECS mode (open-telemetry#36233)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

In ECS mode:
Translate `k8s.job.name`, `k8s.cronjob.name`, `k8s.statefulset.name`,
`k8s.replicaset.name`, `k8s.daemonset.name`, `k8s.container.name` to
`kubernetes.*.name`. Translate `k8s.cluster.name` to
`orchestrator.cluster.name`.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…n ECS mode (open-telemetry#36233)

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

In ECS mode:
Translate `k8s.job.name`, `k8s.cronjob.name`, `k8s.statefulset.name`,
`k8s.replicaset.name`, `k8s.daemonset.name`, `k8s.container.name` to
`kubernetes.*.name`. Translate `k8s.cluster.name` to
`orchestrator.cluster.name`.

<!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. -->
#### Link to tracking issue

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants