Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[processor/k8sattributes] Add support for profiles signal #35983

Closed
mx-psi opened this issue Oct 24, 2024 · 4 comments · Fixed by #35999
Closed

[processor/k8sattributes] Add support for profiles signal #35983

mx-psi opened this issue Oct 24, 2024 · 4 comments · Fixed by #35999
Labels
data:profiles Profiles related issues help wanted Extra attention is needed priority:p2 Medium processor/k8sattributes k8s Attributes processor

Comments

@mx-psi
Copy link
Member

mx-psi commented Oct 24, 2024

Component(s)

processor/k8sattributes

Describe the issue you're reporting

This processor would be useful for testing and validation of the experimental profiling signal, and to replace some functionality available in the eBPF Agent.

As inspiration for how to add support this PR can be used: open-telemetry/opentelemetry-collector/pull/11071 (there is no processor with support as of the writing of this issue)

Example of configuration using profiles (needs service.profilesSupport feature gate to be enabled):

receivers:
  otlp:
    protocols:
      grpc:
exporters:
  otlp:
    endpoint: ${OTLP_ENDPOINT}
service:
  pipelines:
    profiles:
      receivers: [otlp]
      exporters: [otlp]
@mx-psi mx-psi added help wanted Extra attention is needed priority:p2 Medium data:profiles Profiles related issues labels Oct 24, 2024
@github-actions github-actions bot added the processor/k8sattributes k8s Attributes processor label Oct 24, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@haoqixu
Copy link
Member

haoqixu commented Oct 24, 2024

The package go.opentelemetry.io/collector/processor/processorhelper lacks profile support. Should we extend the *helper package or implement the helper struct/functions in a separate package? The same issue exists for receiverhelper and exporterhelper.

@mx-psi
Copy link
Member Author

mx-psi commented Oct 25, 2024

processorhelper only handles telemetry. Since we are going to rework that API, I would prefer to leave telemetry out of the picture for now (same thing we did for receivers, see open-telemetry/opentelemetry-collector#11071 (comment)). For exporters, we have a dedicated module for profiles

@haoqixu
Copy link
Member

haoqixu commented Oct 25, 2024

processorhelper only handles telemetry. Since we are going to rework that API, I would prefer to leave telemetry out of the picture for now (same thing we did for receivers, see open-telemetry/opentelemetry-collector#11071 (comment)). For exporters, we have a dedicated module for profiles

Thank you for the information. I will submit a PR soon.

sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this issue Dec 17, 2024
…etry#35999)

#### Description
Add support for profiles signal to `k8sattributesprocessor`.

#### Link to tracking issue
Fixes open-telemetry#35983

#### Testing
- factory_test.go
- processor_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:profiles Profiles related issues help wanted Extra attention is needed priority:p2 Medium processor/k8sattributes k8s Attributes processor
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants