Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connector/routing] Add ability to route log records based on OTTL log context #35939

Merged

Conversation

djaglowski
Copy link
Member

@djaglowski djaglowski commented Oct 22, 2024

This PR resolves #35948 by adding a context field to routing table items. The default value of context is resource, so that existing users will not see a difference. log context may also be used. Each routing table item may have a difference context. match_once must be true in order to use log context.

@djaglowski djaglowski force-pushed the routing-connector-by-record branch from 5894833 to 5659ade Compare October 24, 2024 20:49
@github-actions github-actions bot requested review from jpkrohling and mwear October 24, 2024 20:51
@djaglowski djaglowski marked this pull request as ready for review October 24, 2024 21:30
@djaglowski djaglowski requested a review from a team as a code owner October 24, 2024 21:30
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple of non-blocking questions.

connector/routingconnector/router.go Show resolved Hide resolved
connector/routingconnector/router.go Show resolved Hide resolved
Copy link
Member Author

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @mwear

connector/routingconnector/router.go Show resolved Hide resolved
connector/routingconnector/router.go Show resolved Hide resolved
@djaglowski djaglowski added Skip Changelog PRs that do not require a CHANGELOG.md entry and removed Skip Changelog PRs that do not require a CHANGELOG.md entry labels Oct 25, 2024
@djaglowski djaglowski merged commit dca11d4 into open-telemetry:main Oct 25, 2024
191 of 194 checks passed
@djaglowski djaglowski deleted the routing-connector-by-record branch October 25, 2024 18:18
@github-actions github-actions bot added this to the next release milestone Oct 25, 2024
jpbarto pushed a commit to jpbarto/opentelemetry-collector-contrib that referenced this pull request Oct 29, 2024
…g context (open-telemetry#35939)

This PR resolves
open-telemetry#35948
by adding a `context` field to routing table items. The default value of
`context` is `resource`, so that existing users will not see a
difference. `log` context may also be used. Each routing table item may
have a difference context. `match_once` must be `true` in order to use
`log` context.
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
…g context (open-telemetry#35939)

This PR resolves
open-telemetry#35948
by adding a `context` field to routing table items. The default value of
`context` is `resource`, so that existing users will not see a
difference. `log` context may also be used. Each routing table item may
have a difference context. `match_once` must be `true` in order to use
`log` context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[connector/routing] Support log record routing
3 participants