Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] skip encoded-compare in testifylint #35900

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[chore] skip encoded-compare in testifylint #35900

merged 1 commit into from
Oct 21, 2024

Conversation

songy23
Copy link
Member

@songy23 songy23 commented Oct 21, 2024

This caused CI failure on mainline: https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/11432753950/job/31803801806

This lint failure seems a false positive because changing the test to JSONEq leads to test failure invalid JSON fomart...

@songy23 songy23 added the ci-cd CI, CD, testing, build issues label Oct 21, 2024
@songy23 songy23 requested a review from a team as a code owner October 21, 2024 17:38
@songy23 songy23 requested a review from mwear October 21, 2024 17:38
evan-bradley
evan-bradley approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. The linting error is definitely a false positive (the string contains two JSON objects separated by a newline, not a single JSON document) and there's no other way to turn off the linting rule that I can see aside from this setting.

@evan-bradley evan-bradley merged commit 79926f8 into open-telemetry:main Oct 21, 2024
164 of 169 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 21, 2024
@songy23 songy23 deleted the ci branch October 21, 2024 18:23
@dashpole dashpole mentioned this pull request Oct 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes

@mwear mwear Awaiting requested review from mwear mwear is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@jpkrohling jpkrohling

Labels
ci-cd CI, CD, testing, build issues
Projects
None yet
Milestone
v0.112.0
Development

Successfully merging this pull request may close these issues.
3 participants
@songy23 @evan-bradley @jpkrohling