Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/azureblobreceiver] support for default auth #35636

Merged
merged 3 commits into from
Oct 8, 2024
Merged

[receiver/azureblobreceiver] support for default auth #35636

merged 3 commits into from
Oct 8, 2024

Conversation

arminfelder
Copy link
Contributor

adds "default" auth, to make the azure go package, autodiscover credentials added by e.g. workload identities

@arminfelder arminfelder requested review from mx-psi and a team as code owners October 7, 2024 10:32
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 7, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@github-actions github-actions bot requested a review from eedorenko October 7, 2024 10:36
mx-psi
mx-psi reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you add a changelog note for your change?

@arminfelder
Copy link
Contributor Author

@mx-psi added a simple changelog, I hope I did it right

@mx-psi mx-psi merged commit 9743104 into open-telemetry:main Oct 8, 2024
155 checks passed
@github-actions github-actions bot added this to the next release milestone Oct 8, 2024
ghost pushed a commit to sematext/opentelemetry-collector-contrib that referenced this pull request Oct 9, 2024
@arminfelder @AkhigbeEromo
[receiver/azureblobreceiver] support for default auth (open-telemetry…
1237541 
…#35636)

adds "default" auth, to make the azure go package, autodiscover
credentials added by e.g. workload identities
@arminfelder arminfelder deleted the feature/azureblobreceiverDefaultAuth branch October 30, 2024 22:55
sbylica-splunk pushed a commit to sbylica-splunk/opentelemetry-collector-contrib that referenced this pull request Dec 17, 2024
@arminfelder @sbylica-splunk
[receiver/azureblobreceiver] support for default auth (open-telemetry…
684e6fd 
…#35636)

adds "default" auth, to make the azure go package, autodiscover
credentials added by e.g. workload identities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mx-psi mx-psi mx-psi approved these changes

@eedorenko eedorenko Awaiting requested review from eedorenko

Assignees

@dashpole dashpole

Labels
receiver/azureblob
Projects
None yet
Milestone
v0.112.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arminfelder @mx-psi @dashpole