[k8sobserver] enable the observation of ingress objects #35539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florian Bacher <[email protected]>
Signed-off-by: Florian Bacher <[email protected]>
ChrsMark
approved these changes
Oct 7, 2024
mowies
approved these changes
Oct 14, 2024
|
/cc @open-telemetry/collector-contrib-approvers |
Co-authored-by: Moritz Wiesinger <[email protected]>
|
Hey @dmitryax could you also take a look? |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
dmitryax
approved these changes
Nov 3, 2024
|
Thanks, @bacherfl! Sorry for the delay |
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
…ry#35539) **Description:** This PR fixes the observation of ingress objects by the k8sobserver. The issue was that the `observe_ingresses` option was not considered in the extension setup, and no informer for the ingress resource type has been created **Link to tracking Issue:** open-telemetry#35324 **Testing:** Added unit tests. Also did manual testing against a k8s cluster to check whether ingress objects are picked up as expected **Documentation:** No change there, as the `observe_ingresses` option was already documented in the readme --------- Signed-off-by: Florian Bacher <[email protected]> Co-authored-by: Moritz Wiesinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR fixes the observation of ingress objects by the k8sobserver. The issue was that the
observe_ingressesoption was not considered in the extension setup, and no informer for the ingress resource type has been createdLink to tracking Issue: #35324
Testing: Added unit tests. Also did manual testing against a k8s cluster to check whether ingress objects are picked up as expected
Documentation: No change there, as the
observe_ingressesoption was already documented in the readme