[chore] Add benchmark for new XML crud functions #35493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bogdandrutu,
evan-bradley,
kentquirk and
TylerHelmuth
TylerHelmuth
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
For the record, here are the results I got when running:
/Users/tylerhelmuth/Library/Caches/JetBrains/GoLand2023.2/tmp/GoLand/___Benchmark_XML_Functions_in_github_com_open_telemetry_opentelemetry_collector_contrib_pkg_ottl_e2e.test -test.v -test.paniconexit0 -test.bench ^\QBenchmark_XML_Functions\E$ -test.run ^$
goos: darwin
goarch: arm64
pkg: github.com/open-telemetry/opentelemetry-collector-contrib/pkg/ottl/e2e
Benchmark_XML_Functions
Benchmark_XML_Functions-10 45488 25384 ns/op 48728 B/op 308 allocs/op
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
The benchmark performs a round trip of operations, getting values from the document, inserting them elsewhere, then removing them, and ultimately overwriting the original value with the "new" (same) value. Resolves open-telemetry#35471
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The benchmark performs a round trip of operations, getting values from the document, inserting them elsewhere, then removing them, and ultimately overwriting the original value with the "new" (same) value.
Resolves #35471