zipkinreceiver: migrate to latest semconv version #35340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narcis96
requested review from
MovieStoreGuy,
andrzej-stencel,
crobert-1 and
a team
as code owners
MovieStoreGuy
approved these changes
Sep 23, 2024
|
Please be sure to add a change log to include that this is being upgraded from/to version of the semantic convension. |
Do we need a changelog entry here? It appears to be a simple dep bump without any user or API impact. Is there something specific a user would want to know with this upgrade? |
crobert-1
approved these changes
Sep 24, 2024
|
With no changes to the emitted data, i don't think a changelog is needed. Will need an issue to follow up bumping to later version of semconv for this receiver |
codeboten
approved these changes
Sep 25, 2024
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
Description: The version of semconv is upgraded from v1.6.1 to v1.12.0 Link to tracking Issue: open-telemetry#22095 Testing: Tests passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The version of semconv is upgraded from v1.6.1 to v1.12.0
Link to tracking Issue: #22095
Testing: Tests passed