Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Enable goleak in kubeletstatsreceiver #35277

Conversation

iblancasa
Copy link
Contributor

@iblancasa iblancasa commented Sep 18, 2024

Related to #30438

…casa/opentelemetry-collector-contrib into enable-goleak-kubeletstatsreceiver
Signed-off-by: Israel Blancas <[email protected]>
@iblancasa iblancasa requested a review from a team as a code owner September 19, 2024 11:08
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crobert-1
Copy link
Member

The leak is still leaking 💧 https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10939763237/job/30371003090?pr=35277 😅

It looks like you're running into #31047 which blocks most of the k8s components from enabling goleak.

@iblancasa
Copy link
Contributor Author

The leak is still leaking 💧 https://github.com/open-telemetry/opentelemetry-collector-contrib/actions/runs/10939763237/job/30371003090?pr=35277 😅

Interesting that I cannot reproduce locally... I'll try again 🤔

Copy link
Contributor

github-actions bot commented Oct 5, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 5, 2024
@github-actions github-actions bot removed the Stale label Oct 9, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 24, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants