Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/sapm] Add priority to pick token from context #35123

Merged

Conversation

asreehari-splunk
Copy link
Contributor

@asreehari-splunk asreehari-splunk commented Sep 10, 2024

Description: Prioritize token in context when accesstokenpassthrough is enabled

Link to tracking Issue:

Testing:

Documentation:

exporter/sapmexporter/exporter.go Outdated Show resolved Hide resolved
exporter/sapmexporter/exporter.go Outdated Show resolved Hide resolved
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the failing linter

exporter/sapmexporter/exporter_test.go Outdated Show resolved Hide resolved
@asreehari-splunk asreehari-splunk force-pushed the OTL-2919/UseTokenFromContext branch 4 times, most recently from 7bfb4cf to 3f66f2c Compare September 10, 2024 22:00
exporter/sapmexporter/exporter.go Outdated Show resolved Hide resolved
exporter/sapmexporter/exporter_test.go Outdated Show resolved Hide resolved
@asreehari-splunk asreehari-splunk force-pushed the OTL-2919/UseTokenFromContext branch from 3f66f2c to 06294a8 Compare September 10, 2024 22:54
@andrzej-stencel andrzej-stencel changed the title Draft: add priority to pick token from context [exporter/sapm] Draft: add priority to pick token from context Sep 11, 2024
@asreehari-splunk asreehari-splunk force-pushed the OTL-2919/UseTokenFromContext branch from 06294a8 to 3782a4f Compare September 11, 2024 16:31
@asreehari-splunk asreehari-splunk force-pushed the OTL-2919/UseTokenFromContext branch 2 times, most recently from 34bf50e to 54659f3 Compare September 11, 2024 18:35
exporter/sapmexporter/exporter.go Outdated Show resolved Hide resolved
@dmitryax dmitryax changed the title [exporter/sapm] Draft: add priority to pick token from context [exporter/sapm] Add priority to pick token from context Sep 11, 2024
@asreehari-splunk asreehari-splunk force-pushed the OTL-2919/UseTokenFromContext branch from 54659f3 to a15f6fa Compare September 11, 2024 18:48
@asreehari-splunk asreehari-splunk force-pushed the OTL-2919/UseTokenFromContext branch from a15f6fa to b8c47dd Compare September 11, 2024 20:25
@dmitryax dmitryax merged commit c2a2213 into open-telemetry:main Sep 11, 2024
155 of 156 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 11, 2024
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
…ry#35123)

Prioritize token in context when accesstokenpassthrough is enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants