[exporter/datadog] Use correct hostname for logs in logs agent pipeline #35058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmd/otelcontribcol
github-actions
bot
requested review from
ankitpatel96,
dineshg13 and
mackjmr
songy23
reviewed
Sep 6, 2024
| @@ -10,7 +10,7 @@ require ( | |||
| github.com/DataDog/datadog-agent/comp/logs/agent/config v0.56.2 | |||
| github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline v0.56.2 | |||
| github.com/DataDog/datadog-agent/comp/otelcol/logsagentpipeline/logsagentpipelineimpl v0.56.2 | |||
| github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter v0.56.2 | |||
| github.com/DataDog/datadog-agent/comp/otelcol/otlp/components/exporter/logsagentexporter v0.58.0-devel.0.20240905201012-b02662b2ba27 | |||
songy23
approved these changes
Sep 6, 2024
|
This PR updates in the same |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…ne (open-telemetry#35058) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Includes bug fix from DataDog/datadog-agent#28870. In gateway deployments using the logs agent feature gate, some logs may be associated with the hostname of the gateway collector instead of the host sending the logs. This fixes this issue by explicitly assigning the mapped log hostname. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> Performed manual tests and added unit test. **Documentation:** <Describe the documentation added.>
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…ne (open-telemetry#35058) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Includes bug fix from DataDog/datadog-agent#28870. In gateway deployments using the logs agent feature gate, some logs may be associated with the hostname of the gateway collector instead of the host sending the logs. This fixes this issue by explicitly assigning the mapped log hostname. **Link to tracking Issue:** <Issue number if applicable> **Testing:** <Describe what testing was performed and which tests were added.> Performed manual tests and added unit test. **Documentation:** <Describe the documentation added.>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Includes bug fix from DataDog/datadog-agent#28870. In gateway deployments using the logs agent feature gate, some logs may be associated with the hostname of the gateway collector instead of the host sending the logs. This fixes this issue by explicitly assigning the mapped log hostname.
Link to tracking Issue:
Testing:
Performed manual tests and added unit test.
Documentation: