Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/hostmetrics] respect env var use in filesystem scraper #35045

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Sep 6, 2024

Description:
In filesystem scraper, do not prefix partitions when using the environment variable HOST_PROC_MOUNTINFO

Link to tracking Issue:
Fixes #35043

…s when using the environment variable HOST_PROC_MOUNTINFO
@atoulme atoulme force-pushed the fix_envvar_filesystem branch from 7e466cf to 8cd21ce Compare September 9, 2024 19:00
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @braydonk can you PTAL as well?

Copy link
Contributor

@braydonk braydonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label Sep 10, 2024
@dmitryax dmitryax merged commit 44bc868 into open-telemetry:main Sep 10, 2024
162 of 163 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 10, 2024
@atoulme atoulme deleted the fix_envvar_filesystem branch September 10, 2024 20:56
jriguera pushed a commit to springernature/opentelemetry-collector-contrib that referenced this pull request Oct 4, 2024
…n-telemetry#35045)

**Description:** 
In filesystem scraper, do not prefix partitions when using the
environment variable HOST_PROC_MOUNTINFO

**Link to tracking Issue:**
Fixes open-telemetry#35043
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Code review completed; ready to merge by maintainers receiver/hostmetrics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[receiver/hostmetrics] Filesystem scraper doesn't respect env var when set
5 participants