Operators with silent errors will log errors as debug and won't return an error #35010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamerJ
force-pushed
the
SamerJ-patch-1
branch
2 times, most recently
from
07e4aba to
6bf0ab0
Compare
SamerJ
force-pushed
the
SamerJ-patch-1
branch
from
6bf0ab0 to
4c27c1b
Compare
SamerJ
changed the title
djaglowski
approved these changes
Sep 5, 2024
SamerJ
force-pushed
the
SamerJ-patch-1
branch
from
cf200b1 to
fc40012
Compare
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…n an error (open-telemetry#35010) An operator configured with silent errors shouldn't log errors while processing log entries. **Description:** Operators that are expected to sometimes fail, can result in error logs that are quite verbose. This aims to address this issue by getting rid of error logs that the user wishes to silence (debug logs instead). By making sure no error is returned, there won't be any need to worry about other components logging error logs. **Link to tracking Issue:** [Issue open-telemetry#35008](open-telemetry#35008) **Testing:** Manually tested as this is a matter of logs.
jriguera
pushed a commit
to springernature/opentelemetry-collector-contrib
that referenced
this pull request
Oct 4, 2024
…n an error (open-telemetry#35010) An operator configured with silent errors shouldn't log errors while processing log entries. **Description:** Operators that are expected to sometimes fail, can result in error logs that are quite verbose. This aims to address this issue by getting rid of error logs that the user wishes to silence (debug logs instead). By making sure no error is returned, there won't be any need to worry about other components logging error logs. **Link to tracking Issue:** [Issue open-telemetry#35008](open-telemetry#35008) **Testing:** Manually tested as this is a matter of logs.
djaglowski
pushed a commit
that referenced
this pull request
Oct 28, 2024
#35834) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixed issue in which Operators with DropOnErrorQuiet are not dropping log entries on error. Note: This issue was introduced by a bug fix meant to ensure Silent Operators are not logging errors (#35010). With this fix, this side effect bug has been resolved. <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes 35010 <!--Describe what testing was performed and which tests were added.--> #### Testing Added UT
jpbarto
pushed a commit
to jpbarto/opentelemetry-collector-contrib
that referenced
this pull request
Oct 29, 2024
open-telemetry#35834) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixed issue in which Operators with DropOnErrorQuiet are not dropping log entries on error. Note: This issue was introduced by a bug fix meant to ensure Silent Operators are not logging errors (open-telemetry#35010). With this fix, this side effect bug has been resolved. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes 35010 <!--Describe what testing was performed and which tests were added.--> #### Testing Added UT
sbylica-splunk
pushed a commit
to sbylica-splunk/opentelemetry-collector-contrib
that referenced
this pull request
Dec 17, 2024
open-telemetry#35834) <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Fixed issue in which Operators with DropOnErrorQuiet are not dropping log entries on error. Note: This issue was introduced by a bug fix meant to ensure Silent Operators are not logging errors (open-telemetry#35010). With this fix, this side effect bug has been resolved. <!-- Issue number (e.g. open-telemetry#1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes 35010 <!--Describe what testing was performed and which tests were added.--> #### Testing Added UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An operator configured with silent errors shouldn't log errors while processing log entries.
Description:
Operators that are expected to sometimes fail, can result in error logs that are quite verbose.
This aims to address this issue by getting rid of error logs that the user wishes to silence (debug logs instead).
By making sure no error is returned, there won't be any need to worry about other components logging error logs.
Link to tracking Issue: Issue #35008
Testing:
Manually tested as this is a matter of logs.