remove oteltestbed collector #34849
Closed
remove oteltestbed collector #34849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this immediately changed the memory consumed by the collector, which is surprising since i didnt change the config: |
Thanks |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
This collector is only used by the load tests. This is confusing because it's a custom distro that isn't shipped anywhere. This PR updates the load tests to use the otelcontribcol which is at least closer to the contrib distro. We should probably move to officially shipped distros in the near future. Signed-off-by: Alex Boten <[email protected]>
Signed-off-by: Alex Boten <[email protected]>
codeboten
force-pushed
the
codeboten/rm-testbedcol
branch
from
b2eca0c
to
c3b3484
Compare
|
The reason a separate build is used is because the contrib build's memory footprint changes based on all components, even if they are not used in the testbed. This means that the testbed's memory thresholds are regularly invalidated and the net result is that tests become very flaky and the thresholds keep getting raised arbitrarily to deal with the problem. Original explaination. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
The generated code was removed in a separate PR and after discussing this we're not ready to remove it yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collector is only used by the load tests. This is confusing because it's a custom distro that isn't shipped anywhere. This PR updates the load tests to use the otelcontribcol which is at least closer to the contrib distro. We should probably move to officially shipped distros in the near future.