Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/elasticsearch] Add span event to traces OTel mapping mode #34831

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented Aug 23, 2024

Description:

Span events are now supported in OTel mapping mode.
They will be routed to logs-${data_stream.dataset}-${data_stream.namespace} if traces_dynamic_index::enabled is true.

Link to tracking Issue:

Testing:

Updated exporter tests

Documentation:

@carsonip carsonip force-pushed the otel-mode-traces-independent-events-pr branch from c66b028 to b95c372 Compare August 30, 2024 10:05
@carsonip carsonip force-pushed the otel-mode-traces-independent-events-pr branch from 5d2859f to 001999c Compare August 30, 2024 11:11
@carsonip carsonip marked this pull request as ready for review August 30, 2024 11:12
@carsonip carsonip requested review from a team and andrzej-stencel August 30, 2024 11:12
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me. Since there's no open issue for this that I'm aware of, I'll defer to code owners to confirm this behavior aligns with the goals of this component 👍

@andrzej-stencel andrzej-stencel added the ready to merge Code review completed; ready to merge by maintainers label Sep 5, 2024
@andrzej-stencel andrzej-stencel merged commit 9a31997 into open-telemetry:main Sep 5, 2024
163 checks passed
@github-actions github-actions bot added this to the next release milestone Sep 5, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
…pen-telemetry#34831)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
  Span events are now supported in OTel mapping mode.
They will be routed to
`logs-${data_stream.dataset}-${data_stream.namespace}` if
`traces_dynamic_index::enabled` is `true`.

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

Updated exporter tests

**Documentation:** <Describe the documentation added.>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/elasticsearch ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants