[chore] Fix windowseventlogreceiver test flakiness #34793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
approved these changes
Aug 21, 2024
pjanotti
changed the title
atoulme
reviewed
Aug 22, 2024
atoulme
approved these changes
Aug 22, 2024
dmitryax
approved these changes
Aug 22, 2024
|
@pjanotti, I'm seeing failures (example) on #34720 which I think might be related to these changes. From what I can tell, we are failing a |
|
Thanks @djaglowski - I'll look into it. |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
) **Description:** There are 3 main issues being addressed on this PR: * There is a race between start and generating the events in the tests: the start require goroutines so a delay before generating the events will be advisable (not perfect but good enough per my tests) * The tests assume that only the tests are generating events in that time window, that is impossible to guarantee on a windows box, so instead of checking for exactly one event they need to get new events and check the event provider instead * The exclusion test checks if zero events were delivered by the receiver, it should check if one not filtered out was received, and this one should be generated after the event from the provider that should be excluded. **Link to tracking Issue:** Fixes open-telemetry#34687 **Testing:** Multiple local runs, we should do a few runs on CI given the runner characteristics. **Documentation:** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There are 3 main issues being addressed on this PR:
Link to tracking Issue:
Fixes #34687
Testing:
Multiple local runs, we should do a few runs on CI given the runner characteristics.
Documentation:
N/A