[opampsupervisor] Add HealthCheckPort configuration parameter #34704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
atoulme,
BinaryFissionGames,
evan-bradley and
tigrannajaryan
dpaasman00
force-pushed
the
supervisor-healthcheck-port-configurable
branch
from
e5ebe01 to
4a8e195
Compare
Comment on lines
132
to
135
| if a.HealthCheckPort > 65535 { | ||
| return errors.New("agent::health_check_port must be a valid port number") | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's also check that the port is not negative
dpaasman00
force-pushed
the
supervisor-healthcheck-port-configurable
branch
from
a1a5237 to
5b54cb6
Compare
BinaryFissionGames
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
This works great for me.
@tigrannajaryan Do you have any objections to this feature in general? I know you were discussing ways to mitigate issues with the random port allocation, but I think this is a good practical solution to the problem for now.
No objections. |
dpaasman00
force-pushed
the
supervisor-healthcheck-port-configurable
branch
2 times, most recently
from
80eddf4 to
03dc166
Compare
dpaasman00
force-pushed
the
supervisor-healthcheck-port-configurable
branch
from
03dc166 to
bb67282
Compare
evan-bradley
approved these changes
Sep 3, 2024
songy23
added
the
ready to merge
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…elemetry#34704) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> Add a new configuration parameter to `agent` called `health_check_port`. If this is set, then the supervisor will configure the agent's healthcheck extension to use the given port. If it is unset, then we will grab a random port same as before. **Link to tracking Issue:** open-telemetry#34643 **Testing:** <Describe what testing was performed and which tests were added.> - Updated config validation tests - Verified that healthcheck extension is configured with the correct port and works as expected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a new configuration parameter to
agentcalledhealth_check_port. If this is set, then the supervisor will configure the agent's healthcheck extension to use the given port. If it is unset, then we will grab a random port same as before.Link to tracking Issue: #34643
Testing: