[chore] Restore Lint on Windows #34656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
yep, there are some things to be fixed before we can consider merging this one... |
pjanotti
commented
Aug 13, 2024
| @@ -54,7 +54,7 @@ $(TOOLS_BIN_DIR): | |||
| mkdir -p $@ | |||
|
|
|||
| $(TOOLS_BIN_NAMES): $(TOOLS_BIN_DIR) $(TOOLS_MOD_DIR)/go.mod | |||
| cd $(TOOLS_MOD_DIR) && $(GOCMD) build -o $@ -trimpath $(filter %/$(notdir $@),$(TOOLS_PKG_NAMES)) | |||
| cd $(TOOLS_MOD_DIR) && GOOS="" $(GOCMD) build -o $@ -trimpath $(filter %/$(notdir $@),$(TOOLS_PKG_NAMES)) | |||
There was a problem hiding this comment.
It seems reasonable to enforce this here since these tools are be used locally - at first I can't see a typical case in which we want this to follow GOOS. This is also showing that the step to check the cache, used to skip make install-tools is also wrong.
crobert-1
approved these changes
Aug 13, 2024
dmitryax
reviewed
Aug 13, 2024
djaglowski
approved these changes
Aug 14, 2024
dmitryax
approved these changes
Aug 14, 2024
crobert-1
added
the
ready to merge
|
Opened #34691 to track the |
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
Lint is not happening for `GOOS=windows` . This change restores lint for Windows on CI runs. We may have to fix a bunch of lint issues before being able to merge this one. Noticed while looking at the failures from open-telemetry#34639
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lint is not happening for
GOOS=windows. This change restores lint for Windows on CI runs.We may have to fix a bunch of lint issues before being able to merge this one.
Noticed while looking at the failures from #34639