Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/jaegerreceiver] Thrift packets processing metrics #34464

Closed

Conversation

larsn777
Copy link
Contributor

@larsn777 larsn777 commented Aug 7, 2024

Description:
Added metrics for the number of Thrift packets processed and rejected.
These metrics will help to monitor possible data loss on Jaeger receiver component.

Link to tracking Issue:
#34462

Testing:

Documentation:

@larsn777 larsn777 requested a review from yurishkuro as a code owner August 7, 2024 11:22
@larsn777 larsn777 requested review from a team and djaglowski August 7, 2024 11:22
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 23, 2024
@yurishkuro
Copy link
Member

@larsn777 looks like there are merge conflicts that need to be resolved

@github-actions github-actions bot removed the Stale label Aug 24, 2024
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @larsn777, please resolve the merge conflicts when you get a chance.

@larsn777
Copy link
Contributor Author

@yurishkuro @mwear Sorry for the late response.
I resolved the conflicts and also committed a small fix and update for the autogenerated telemetry code.

Copy link
Contributor

github-actions bot commented Oct 3, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Oct 3, 2024
Copy link
Contributor

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants