Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] Fix some of the load tests #33975

Merged
merged 3 commits into from
Jul 9, 2024

Conversation

mowies
Copy link
Member

@mowies mowies commented Jul 9, 2024

Description:

This PR tries to fix some of the load tests.

Link to tracking Issue: no issue

Testing: load tests are particularly hard to test since they only run on main branch and also on self hosted runners. which makes them impossible to fully reproduce on a fork... I tested them locally and got better results than upstream.

Documentation: NA

mowies added 3 commits July 8, 2024 17:20
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
Signed-off-by: Moritz Wiesinger <[email protected]>
@mowies mowies marked this pull request as ready for review July 9, 2024 10:04
@mowies mowies requested review from a team and MovieStoreGuy July 9, 2024 10:04
@mx-psi
Copy link
Member

mx-psi commented Jul 9, 2024

oad tests are particularly hard to test since they only run on main branch and also on self hosted runners. which makes them impossible to fully reproduce on a fork... I tested them locally and got better results than upstream.

We could add a similar label to "Run on Windows" for load tests if that helps. Would you be up for that? (Not needed to merge this PR IMO, can be done in parallel)

@mowies
Copy link
Member Author

mowies commented Jul 9, 2024

Yes I think that could work. Although outside contributors (like myself) could still not add the label themselves, except if we also add it to the /label comment/command.

@mowies
Copy link
Member Author

mowies commented Jul 9, 2024

And yes, I could add that feature :D

@mx-psi
Copy link
Member

mx-psi commented Jul 9, 2024

Yes I think that could work. Although outside contributors (like myself) could still not add the label themselves, except if we also add it to the /label comment/command.

That's fair, I still see it as a net improvement though

@mx-psi mx-psi merged commit c6f2345 into open-telemetry:main Jul 9, 2024
156 checks passed
@mowies mowies deleted the fix-load-tests branch July 9, 2024 11:28
@github-actions github-actions bot added this to the next release milestone Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants