[wip][chore] migrate away from opencensus over to otel #33664
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This migrates the opencensus metrics to opentelemetry via mdatagen. Note that there is functionality to override the metric names in this exporter that isn't supported out of the box w/ mdatagen. This will be configurable via the configuration of metric views in `service::telemetry::metrics::views` in the future. One option to get around this in the short term would be to not use mdatagen and just use otel directly. Closes open-telemetry#33471 Signed-off-by: Alex Boten <[email protected]>
|
Thanks @codeboten I can try to look at it soon. |
|
Thanks @atoulme, any update on this? |
|
FYI, looks like a lot of checks are failing and from what I can tell they're related to this PR. It would be helpful to fix those before reviewing. ETA: Is this ready for review, or still a draft? |
|
@crobert-1 i was leaving this in draft until I know which way I should be addressing the shortcomings of this PR (regarding the configuration for the component that currently allows users to rename their emitted metrics) |
codeboten
added a commit
to codeboten/opentelemetry-collector-contrib
that referenced
this pull request
Jul 4, 2024
This is an alternative to open-telemetry#33664, since mdatagen doesn't support changing metric names, this substitutes the opencensus sdk calls with otel directly. Signed-off-by: Alex Boten <[email protected]>
|
As per #33924 (comment), going to close this one in favour of #33924 |
codeboten
added a commit
that referenced
this pull request
Jul 8, 2024
This is an alternative to #33664, since mdatagen doesn't support changing metric names, this substitutes the opencensus sdk calls with otel directly. Pinging @atoulme @dmitryax @crobert-1 to guide which of the two approaches is preferred. This component is the last one blocking the removal of the opencensus bridge in core. Closes #33471 Closes #29867 ~NOTE: tests need to be fixed, but i wanted to propose this alternative before spending time to fix the tests~ --------- Signed-off-by: Alex Boten <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the opencensus metrics to opentelemetry via mdatagen. Note that there is functionality to override the metric names in this exporter that isn't supported out of the box w/ mdatagen. This will be configurable via the configuration of metric views in
service::telemetry::metrics::viewsin the future.One option to get around this in the short term would be to not use mdatagen and just use otel directly.
Closes #33471
Pinging @atoulme as you may have thoughts on how to move this work forward.