Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTel-Arrow components to contribcol; mark these alpha #33628

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

jmacd
Copy link
Contributor

@jmacd jmacd commented Jun 18, 2024

Description: Labels the otelarrowexporter and otelarrowreceiver as alpha, adds them to the contribcol.

Link to tracking Issue: #26491

@jmacd jmacd requested a review from a team June 18, 2024 13:44
@jmacd jmacd requested a review from codeboten as a code owner June 18, 2024 13:44
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Jun 18, 2024
@github-actions github-actions bot requested a review from moh-osman3 June 18, 2024 13:44
@crobert-1
Copy link
Member

v0.103.0 is currently being released, so this will need to be updated once the release is complete.

Also, just in case it's not obvious, make sure to submit a PR to the releases repository to add these components to the contrib distribution, as described here.

Copy link

@lquerel lquerel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atoulme
Copy link
Contributor

atoulme commented Jun 18, 2024

Yes, I'd wait for 0.103.0 to be out and then fix conflicts.

@jmacd
Copy link
Contributor Author

jmacd commented Jun 20, 2024

Also, just in case it's not obvious, make sure to submit a PR to the releases repository to add these components to the contrib distribution, as described here.

@crobert-1 Asking for slight clarification: The internal/components code has no documentation -- the above text is the only reference to it -- and it appears to be auto-generated? Is it the same as cmd/otelcontribcol/components.go?

@jmacd
Copy link
Contributor Author

jmacd commented Jun 20, 2024

@crobert-1 Also, who determines which distribution these components can go into? Speaking as the developer, we are hoping to recommend OTel-Arrow as a more-performant and 100% compatible replacement for the OTLP exporter and receiver. Therefore, I would recommend adding OTel-Arrow components to every distribution that has an OTLP exporter or receiver component.

@jmacd
Copy link
Contributor Author

jmacd commented Jun 20, 2024

@codeboten
Copy link
Contributor

Also, who determines which distribution these components can go into

The rules for inclusion are listed in each distribution's readme file listed at the bottom of the doc here: https://github.com/open-telemetry/opentelemetry-collector-releases

@crobert-1
Copy link
Member

crobert-1 commented Jun 20, 2024

Also, just in case it's not obvious, make sure to submit a PR to the releases repository to add these components to the contrib distribution, as described here.

@crobert-1 Asking for slight clarification: The internal/components code has no documentation -- the above text is the only reference to it -- and it appears to be auto-generated? Is it the same as cmd/otelcontribcol/components.go?

Thanks for pointing that out, it looks like the internal/components documentation is out of date, I've submitted #33690 to remove this reference.

Edit 1: I'm honestly not sure what's going on here, I'll have to investigate a bit more.

Edit 2: The PR has been merged, so this is no longer required.

@jmacd jmacd added the ready to merge Code review completed; ready to merge by maintainers label Jun 21, 2024
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @jmacd

@codeboten codeboten merged commit a99a0a2 into open-telemetry:main Jun 21, 2024
161 checks passed
@github-actions github-actions bot added this to the next release milestone Jun 21, 2024
martin-majlis-s1 pushed a commit to scalyr/opentelemetry-collector-contrib that referenced this pull request Jun 24, 2024
…etry#33628)

**Description:** Labels the `otelarrowexporter` and `otelarrowreceiver`
as alpha, adds them to the contribcol.

**Link to tracking Issue:** open-telemetry#26491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd/otelcontribcol otelcontribcol command exporter/otelarrow ready to merge Code review completed; ready to merge by maintainers receiver/otelarrow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants