-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTel-Arrow components to contribcol; mark these alpha #33628
Conversation
Also, just in case it's not obvious, make sure to submit a PR to the releases repository to add these components to the contrib distribution, as described here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, I'd wait for 0.103.0 to be out and then fix conflicts. |
…tor-contrib into jmacd/arrow_alpha
@crobert-1 Asking for slight clarification: The internal/components code has no documentation -- the above text is the only reference to it -- and it appears to be auto-generated? Is it the same as cmd/otelcontribcol/components.go? |
@crobert-1 Also, who determines which distribution these components can go into? Speaking as the developer, we are hoping to recommend OTel-Arrow as a more-performant and 100% compatible replacement for the OTLP exporter and receiver. Therefore, I would recommend adding OTel-Arrow components to every distribution that has an OTLP exporter or receiver component. |
The rules for inclusion are listed in each distribution's readme file listed at the bottom of the doc here: https://github.com/open-telemetry/opentelemetry-collector-releases |
Thanks for pointing that out, it looks like the Edit 1: I'm honestly not sure what's going on here, I'll have to investigate a bit more. Edit 2: The PR has been merged, so this is no longer required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks @jmacd
…etry#33628) **Description:** Labels the `otelarrowexporter` and `otelarrowreceiver` as alpha, adds them to the contribcol. **Link to tracking Issue:** open-telemetry#26491
Description: Labels the
otelarrowexporter
andotelarrowreceiver
as alpha, adds them to the contribcol.Link to tracking Issue: #26491