[exporter/elasticsearch] Add initial support for metrics #33513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrzej-stencel
commented
Jun 12, 2024
andrzej-stencel
force-pushed
the
add-metrics-to-elasticsearch-exporter
branch
from
c3bdb47 to
19af1ea
Compare
axw
reviewed
Jun 14, 2024
…ticsearch-exporter
…ticsearch-exporter
We don't want cryptographic hashing, we want fast hashing. Using hash/fnv as recommended in [contribution docs](https://github.com/open-telemetry/opentelemetry-collector/blob/v0.102.1/CONTRIBUTING.md#recommended-libraries--defaults). Also changed to hash by uint32 instead of string because I believe that is sufficient. Also added hashing of attribute keys, which was missing. Changed BigEndian to LittleEndian for consistency, although it doesn't really matter.
When any of the documents created for a metrics slice cannot be serialized, reject the whole metrics slice.
Thank you so much @axw for the review, your comments were very helpful! Keep them coming! 🙏 |
axw
approved these changes
Jun 18, 2024
felixbarny
reviewed
Jun 19, 2024
…ticsearch-exporter
carsonip
reviewed
Jun 24, 2024
Co-authored-by: Carson Ip <[email protected]>
carsonip
approved these changes
Jun 24, 2024
Co-authored-by: Carson Ip <[email protected]>
carsonip
approved these changes
Jun 25, 2024
mx-psi
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds initial support for metrics. Currently only Sum ang Gauge metric types are supported, other metric types are ignored.
Testing:
Added unit tests.
Documentation:
Added docs in component README.