Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][receiver/kafkametrics] Added supported versions section #33345

Merged

Conversation

samiura
Copy link

@samiura samiura commented Jun 3, 2024

Description: Based on the tests performed on Splunk distribution using Kafkametrics receiver.

Closes #33206

@samiura samiura requested a review from dmitryax as a code owner June 3, 2024 21:07
@samiura samiura requested a review from a team June 3, 2024 21:07
@samiura samiura changed the title Added supported versions section [chore] Added supported versions section Jun 3, 2024
@samiura
Copy link
Author

samiura commented Jun 3, 2024

@atoulme Can you please kickstart the changelog CI/CD check? I submitted without [chore] and it is failing.

@crobert-1 crobert-1 added documentation Improvements or additions to documentation Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jun 3, 2024
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jun 18, 2024
@samiura samiura force-pushed the kafkametrics-receiver-version-docs branch from 328ba4d to 5c08b8b Compare June 20, 2024 13:45
@crobert-1
Copy link
Member

Based on the tests performed on Splunk distribution using Kafkametrics receiver.

Can those tests be moved upstream to this repo instead? That way the tests that show version X is supported are running alongside the documented supported versions.

@samiura
Copy link
Author

samiura commented Jun 20, 2024

Based on the tests performed on Splunk distribution using Kafkametrics receiver.

Can those tests be moved upstream to this repo instead? That way the tests that show version X is supported are running alongside the documented supported versions.

Those are manual tests to validate needed for the auto-discovery testing of the Splunk distribution. The reason for this PR since we do not have any supported version(s) mentioned. If the ask is to add integration tests this is beyond this PR.

@samiura samiura closed this Jun 20, 2024
@crobert-1
Copy link
Member

Sorry for the confusion, from the description it looked like the Splunk distro had existing tests to ensure the listed versions are supported. I don't think tests are required at this point to show support, but it would be nice. It doesn't have to block this PR, from my perspective.

@crobert-1 crobert-1 reopened this Jun 20, 2024
@github-actions github-actions bot removed the Stale label Jun 21, 2024
@samiura samiura force-pushed the kafkametrics-receiver-version-docs branch from 7e7ace7 to c901b09 Compare July 3, 2024 21:50
@jpkrohling jpkrohling changed the title [chore] Added supported versions section [chore][receiver/kafkametrics] Added supported versions section Jul 4, 2024
@codeboten codeboten merged commit f5d54da into open-telemetry:main Jul 4, 2024
138 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation receiver/kafkametrics Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supported Kafka version missing
5 participants