Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split target allocator into an internal package #33223

Merged
merged 5 commits into from
Aug 28, 2024
Merged

Split target allocator into an internal package #33223

merged 5 commits into from
Aug 28, 2024

Conversation

dashpole
Copy link
Contributor

@dashpole dashpole commented May 24, 2024 •
edited
Loading

Fixes #33146

@dashpole dashpole mentioned this pull request May 24, 2024
Closed
@github-actions github-actions bot added the receiver/prometheus Prometheus receiver label May 24, 2024
@github-actions github-actions bot requested a review from Aneurysm9 May 24, 2024 21:01
@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 29, 2024
@dashpole dashpole marked this pull request as ready for review May 29, 2024 02:16
@dashpole dashpole requested a review from a team May 29, 2024 02:16
@dashpole dashpole changed the title WIP: Split target allocator into an internal package Split target allocator into an internal package May 29, 2024
@dashpole dashpole force-pushed the split_target_allocator branch 4 times, most recently from d882bd4 to 9c5e04f Compare May 29, 2024 19:42
swiatekm
swiatekm approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see any issues, speaking as a potential codeowner of this new package.

@dashpole dashpole removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 11, 2024
@rashmichandrashekar
Copy link
Contributor

rashmichandrashekar commented Jun 18, 2024 •
edited
Loading

@dashpole - Will this be merged soon? I can make the changes for this PR based on new changes - #32127 and address comments from the new owner - @swiatekm-sumo

@dashpole
Copy link
Contributor Author

@andrzej-stencel do you have time to give this another pass?

@rashmichandrashekar
Copy link
Contributor

rashmichandrashekar commented Jun 30, 2024 •
edited
Loading

@andrzej-stencel do you have time to give this another pass?

Following up. @dashpole - If this is taking a little longer, could you and @swiatekm-sumo please review my other PR-#32127 so that I can get it merged, I have adressed the other comments and removed the external library. Hoping to get this merged as this has been waiting for several months.

@github-actions GitHub Actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Jul 24, 2024
@github-actions github-actions bot removed the Stale label Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2024

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Aug 8, 2024
@andrzej-stencel
Copy link
Member

@dashpole sorry this took so long. Can you check the conflicts?

@github-actions github-actions bot removed the Stale label Aug 19, 2024
@dashpole
Copy link
Contributor Author

@andrzej-stencel rebased.

cc @rashmichandrashekar @ItielOlenick

This refactoring includes work you did in #34035 and #32127.

@andrzej-stencel andrzej-stencel merged commit cc47013 into open-telemetry:main Aug 28, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Aug 28, 2024
f7o pushed a commit to f7o/opentelemetry-collector-contrib that referenced this pull request Sep 12, 2024
@dashpole @f7o
Split target allocator into an internal package (open-telemetry#33223)
06abd5c 
Fixes
open-telemetry#33146
okankoAMZ pushed a commit to amazon-contributing/opentelemetry-collector-contrib that referenced this pull request Oct 11, 2024
@dashpole @okankoAMZ
Split target allocator into an internal package (open-telemetry#33223)
80182f7 
Fixes
open-telemetry#33146
okankoAMZ added a commit to amazon-contributing/opentelemetry-collector-contrib that referenced this pull request Oct 14, 2024
@okankoAMZ @dashpole
Target Allocator Module for Prometheus Receiver (#240)
a6dbc1d 
* Split target allocator into an internal package (open-telemetry#33223)

Fixes
open-telemetry#33146

* basic working copy

* Added k8 test back

---------

Co-authored-by: David Ashpole <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swiatekm swiatekm swiatekm approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

Assignees

@andrzej-stencel andrzej-stencel

Labels
receiver/prometheus Prometheus receiver
Projects
None yet
Milestone
v0.109.0
Development

Successfully merging this pull request may close these issues.

[receiver/prometheus] Split target allocator into internal package
4 participants
@dashpole @rashmichandrashekar @andrzej-stencel @swiatekm