Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][exporter/elasticsearch] Fix TestExporter_PushEvent flaky test #32917

Merged

Conversation

carsonip
Copy link
Contributor

@carsonip carsonip commented May 7, 2024

Description:

Fix a flaky test from #31694 due to non-deterministic JSON key order.

Link to tracking Issue: Closes #32910

@carsonip carsonip requested review from a team and djaglowski May 7, 2024 15:48
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@crobert-1 crobert-1 added the ready to merge Code review completed; ready to merge by maintainers label May 7, 2024
@crobert-1
Copy link
Member

Thanks for the quick resolution here, @carsonip, really appreciate it!

@TylerHelmuth TylerHelmuth merged commit 7f2b1b4 into open-telemetry:main May 7, 2024
167 checks passed
@github-actions github-actions bot added this to the next release milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/elasticsearch ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test - TestExporter_PushEvent/publish_with_ecs_encoding
5 participants