Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmd/opampsupervisor]: Configure the ppid option in the opamp extension #32875

Merged

Conversation

BinaryFissionGames
Copy link
Contributor

Description:

  • Configures the PPID of the opamp extension in the supervisor. This allows the collector to detect if the supervisor exits and shut itself down.

Link to tracking Issue: Closes #32189

Testing:

  • Manually tested by starting the supervisor, then kill -9'ing the supervisor. The collector previously would have still been running, but now shuts itself down. Doing this you can also see the following log:
2024-05-06T14:52:31.010-0400	error	[email protected]/collector.go:278	Asynchronous error received, terminating process	{"error": "collector was orphaned, process with pid 38908 does not exist"}

Documentation:
Added orphan_detection_interval to the spec as a configurable option

@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review May 7, 2024 18:11
@BinaryFissionGames BinaryFissionGames requested a review from a team May 7, 2024 18:11
@evan-bradley
Copy link
Contributor

Could you resolve the conflicts?

@BinaryFissionGames
Copy link
Contributor Author

@evan-bradley I've resolved the conflicts and merged in the latest changes from main.

@evan-bradley evan-bradley merged commit e783923 into open-telemetry:main May 16, 2024
162 checks passed
@github-actions github-actions bot added this to the next release milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cmd/opampsupervisor] Supervisor may leak collector process
4 participants