Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[receiver/vcenter] Adds vApp Resource Attributes to Relevant VM Resources #32673

Merged

Conversation

StefanKurek
Copy link
Contributor

Description:
When VMs have a vApp parent rather than a Resource Pool parent, rather than vcenter.resource_pool.name and vcenter.resource_pool.inventory_path resource attributes getting added to the VM resource, vcenter.virtual_app.name and vcenter.virtual_app.inventory_path resource attributes will be added for that VM instead. This way, VMs directly under vApps can still be human identifiable (especially if multiple VMs share the same name).

These new attributes will be disabled by default and will have to be manually enabled in the config.

Link to tracking Issue:
#32557

Testing:
Unit/integration tests updated and tested. Local environment tested.

Documentation:
New documentation generated based on the metadata.

@StefanKurek StefanKurek requested a review from djaglowski as a code owner April 24, 2024 17:25
@StefanKurek StefanKurek requested a review from a team April 24, 2024 17:25
@github-actions github-actions bot requested a review from schmikei April 24, 2024 17:26
@StefanKurek StefanKurek force-pushed the fix/vcenterreceiver-vapp-attributes branch from 801e5e4 to c09b115 Compare April 24, 2024 20:54
@StefanKurek StefanKurek force-pushed the fix/vcenterreceiver-vapp-attributes branch from c09b115 to 2b71603 Compare April 24, 2024 21:40
@djaglowski djaglowski merged commit 2dbdca3 into open-telemetry:main Apr 25, 2024
171 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 25, 2024
@StefanKurek StefanKurek deleted the fix/vcenterreceiver-vapp-attributes branch April 25, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants