-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vcenterreceiver: Adds vcenter.datacenter.name attributes to all resource types #32528
Merged
djaglowski
merged 4 commits into
open-telemetry:main
from
observIQ:feat/vcenterreceiver-datacenter-attrs
Apr 24, 2024
Merged
vcenterreceiver: Adds vcenter.datacenter.name attributes to all resource types #32528
djaglowski
merged 4 commits into
open-telemetry:main
from
observIQ:feat/vcenterreceiver-datacenter-attrs
Apr 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKurek
force-pushed
the
feat/vcenterreceiver-datacenter-attrs
branch
5 times, most recently
from
April 18, 2024 20:49
5f23064
to
88cef28
Compare
StefanKurek
force-pushed
the
feat/vcenterreceiver-datacenter-attrs
branch
2 times, most recently
from
April 18, 2024 21:12
da505e8
to
c71b871
Compare
djaglowski
reviewed
Apr 19, 2024
StefanKurek
force-pushed
the
feat/vcenterreceiver-datacenter-attrs
branch
from
April 19, 2024 17:20
b2bbfc9
to
bd96792
Compare
StefanKurek
force-pushed
the
feat/vcenterreceiver-datacenter-attrs
branch
3 times, most recently
from
April 23, 2024 21:03
fb970ad
to
5bb5089
Compare
@djaglowski should be ready for your review now. Also added the warning in the metadata for the new resource attribute. |
djaglowski
approved these changes
Apr 24, 2024
vcenterreceiver `vcenter.datacenter.name` resource attribute is disabled by default. adds warning message that it will be enabled starting in release v.0.100.0.
StefanKurek
force-pushed
the
feat/vcenterreceiver-datacenter-attrs
branch
from
April 24, 2024 15:43
9d06538
to
53e4669
Compare
@djaglowski should have all conflicts fixed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds
vcenter.datacenter.name
attribute for every resource type. This ensures uniqueness in cases where more than one datacenter exists.Link to tracking Issue:
#32531
Testing:
Unit/integration tests updated and tested. Local environment tested.
Documentation:
Documentation regenerated.