Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/awskinesis] use cached credentials provider #32415

Merged

Conversation

jamesmoessis
Copy link
Contributor

Description:

Wraps the AssumeRoleProvider in a CachedCredentials provider, in the case the AWS role is explicitly specified in the configuration. This prevents a role assumption from happening every API call.

This was causing us to get rate limited by AWS STS since it was not caching credentials.

The previous configuration basically fulfills the scenario described in the AWS Go SDK V2 docs:

All credential providers passed to or returned by LoadDefaultConfig are wrapped in a CredentialsCache automatically. This enables caching and concurrency safe credential access. If you explicitly configure a provider on aws.Config directly you must explicitly wrap the provider with this type using NewCredentialsCache.

Link to tracking Issue: N/A

Testing: N/A

@jamesmoessis jamesmoessis requested a review from a team April 16, 2024 04:17
@MovieStoreGuy MovieStoreGuy merged commit 8dce114 into open-telemetry:main Apr 16, 2024
170 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants