Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pkg/ottl] Add isList OTTL Function #32392

Merged
merged 16 commits into from
Apr 17, 2024
Merged

Conversation

strawgate
Copy link
Contributor

Description:
Add isList OTTL function that returns true if the target is a slice and returns false if it is not

Link to tracking Issue: #27870

Testing: Added tests

Documentation: Updated readme and added changelog entry

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this. Could you also put a test in pkg/ottl/e2e/e2e_test.go in the Test_e2e_converters function?

pkg/ottl/ottlfuncs/func_is_list.go Outdated Show resolved Hide resolved
@strawgate
Copy link
Contributor Author

Incorporated provided feedback!

Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pkg/ottl/ottlfuncs/func_is_list.go Outdated Show resolved Hide resolved
pkg/ottl/ottlfuncs/func_is_list.go Outdated Show resolved Hide resolved
@strawgate
Copy link
Contributor Author

Incorporated feedback and updated branch

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Apr 16, 2024
@dmitryax dmitryax merged commit a84971c into open-telemetry:main Apr 17, 2024
161 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg/ottl ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants