-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pkg/ottl] Add isList OTTL Function #32392
Conversation
Add isList that allows type checking slices, tests, expression tests, and update readme
Update references from slice to List Co-authored-by: Tyler Helmuth <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this. Could you also put a test in pkg/ottl/e2e/e2e_test.go
in the Test_e2e_converters
function?
Incorporated provided feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Incorporated feedback and updated branch |
Description:
Add isList OTTL function that returns true if the target is a slice and returns false if it is not
Link to tracking Issue: #27870
Testing: Added tests
Documentation: Updated readme and added changelog entry