[chore][receiver/azureeventhub] Enable goleak check #32364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Apr 13, 2024
atoulme
approved these changes
Apr 13, 2024
djaglowski
pushed a commit
that referenced
this pull request
Apr 16, 2024
**Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> As explained [here](#30438 (comment)), components need to cancel all their work and background tasks before returning from `Shutdown`. My original [change for this component](#32364) to add `goleak` testing worked around the proper behavior. This PR fully addresses the `Shutdown` functionality to ensure the component behaves the way the spec requires. **Link to tracking Issue:** <Issue number if applicable> #30438 **Testing:** <Describe what testing was performed and which tests were added.> Tests are passing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This enables
goleakchecks for the Azure Event Hub receiver to help ensure no goroutines are being leaked. This is a test only change, some goroutines were being detected as leaks simply because of the context.Background lifecycle. Using a cancel shows everything gets shutdown properly.Link to tracking Issue:
#30438
Testing:
All existing tests are passing, as well as added
goleakcheck.