-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore][exporter/sumologic]: add deduplicateErrors
and decomposeHistograms
functions
#32316
[chore][exporter/sumologic]: add deduplicateErrors
and decomposeHistograms
functions
#32316
Conversation
6655b33
to
80581cc
Compare
@astencel-sumo could you add label to skip changelog please 🙏 ? |
aba1c53
to
882eb89
Compare
Signed-off-by: Dominik Rosiek <[email protected]>
882eb89
to
d37ac30
Compare
@swiatekm-sumo, @astencel-sumo Please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, this pull request adds code that is not used. I don't think this is the right way to split a big pull request into smaller chunks.
A pull request should only add/modify code that is used. Code that is not used is effectively dead code and should not be added unless/until it's actually used.
I disagree. There is a lot of dependencies in the code and this is the simplest way to move the code in small chunks. If I would have to use it, I would have to modify half of the code in addition to those files, which already takes over 400 lines. As all files which do not modify old code are added in this PR, I would like to split next changes per signal, so they will be consistent and they will be marked as breaking changes. |
There was a voice from another maintainer saying that this is OK because there's the draft PR that shows the full picture, which makes sense. I'm unblocking this, sorry if I was too zealous about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To summarize, this PR introduces two new functions that can be used by the component:
- deduplicateErrors
- decomposeHistograms
I've reviewed this code like I would a library that delivers those functions, and the functions are 👌 .
deduplicateErrors
and decomposeHistograms
functions
Description:
Adds files from Sumo Logic Distribution for OpenTelemetry which are new in order to simplify review and make simpler to move the whole component.
This PR is made to simplify #32315
Link to tracking Issue:
#31479
Testing:
Unit Tests, also this code is use by our customers and internally. It is not used by now by the component, but will be when migration will be finished
Documentation: N/A