[statsdreceiver] fixup metamonitoring #32309
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the statsd receiver does not currently emit metrics or traces about its own internal operations, making it difficult to understand if it's working properly. this introduces an integration w/ the receiverhelper.ObsReport helper, which is the standard way to emit this information. this also changes how the transport debug logs are emitted; they are now logged via a new transport.Logger interface; the primary reason for this is to avoid confusion w/ the naming--the 'reporter' is now the ObsReport instance, and what the transport.Reporter really was doing was simply emitting debug logs.
diurnalist
force-pushed
the
f/statsd-metamon
branch
from
7dda2a3 to
6626803
Compare
diurnalist
changed the title
|
fixes #32335 (i had to file the issue to pass the changelog check) |
|
this is an alternate implementation to #31839 - the approach in this PR uses the standard ObsReporter helper and hooks it onto the flush function. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
duplicated by #33415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
the statsd receiver does not currently emit metrics or traces about its own internal operations, making it difficult to understand if it's working properly. this introduces an integration w/ the receiverhelper.ObsReport helper, which is the standard way to emit this information.
this also changes how the transport debug logs are emitted; they are now logged via a new transport.Logger interface; the primary reason for this is to avoid confusion w/ the naming--the 'reporter' is now the ObsReport instance, and what the transport.Reporter really was doing was simply emitting debug logs.
Link to tracking Issue: #32335
Testing:
no new tests are added, but existing tests are updated to pass.
Documentation:
n/a