Prometheus Receiver: Unregister self-observability metrics on Shutdown #32202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
fatsheep9146,
jpkrohling,
Aneurysm9,
mx-psi,
songy23 and
dmitryax
as code owners
github-actions
bot
added
cmd/configschema
github-actions
bot
requested review from
bertysentry,
chrroberts-pure,
dgoscn,
dineshg13,
gouthamve and
gramidt
github-actions
bot
requested review from
liustanley,
mackjmr,
mar4uk and
rapphil
dashpole
force-pushed
the
prom_unregister_metrics
branch
from
bddb719 to
4f8dfe1
Compare
djaglowski
approved these changes
Apr 5, 2024
songy23
approved these changes
Apr 5, 2024
Aneurysm9
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Prometheus libraries will currently fail to initialize if they are called more than once for the same component name. This is because it attempts to register the same self-observability metrics, which isn't allowed by the Prometheus client. To work around this, Unregister all self-observability metrics during Shutdown.
This updates the prometheus dependency to an unreleased version to pull in prometheus/prometheus#13897 and prometheus/prometheus#13896.
Link to tracking Issue:
Fixes #32123
Testing:
Unit test added.
Documentation:
N/A
cc @cpheps @djaglowski