[pkg/stanza] Switch from SugaredLogger to Logger #32177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-rm-sugared
branch
from
871279f to
1a24d74
Compare
djaglowski
force-pushed
the
pkg-stanza-rm-sugared
branch
3 times, most recently
from
7bb8633 to
1a5a872
Compare
djaglowski
force-pushed
the
pkg-stanza-rm-sugared
branch
from
1a5a872 to
a6c670a
Compare
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
djaglowski
pushed a commit
that referenced
this pull request
Apr 24, 2024
…erface (#32662) **Description:** <Describe what has changed.> <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> This PR resumes the work from #31618. The goal is to pass in the `component.TelemetrySettings` so as to use them later in various ways: 1) report the filelog's state stats: #31544 2) switch from `SugaredLogger` to `Logger`: #32177 More about the breaking change decision at #31618 (comment). **Link to tracking Issue:** <Issue number if applicable> #31256 **Testing:** <Describe what testing was performed and which tests were added.> Testing suite got updated. #### Manual Testing 1. ```yaml receivers: filelog: start_at: end include: - /var/log/busybox/refactroring_test.log operators: - id: addon type: add field: attributes.extra value: my-val exporters: debug: verbosity: detailed service: pipelines: logs: receivers: [filelog] exporters: [debug] processors: [] ``` 2. `./bin/otelcontribcol_linux_amd64 --config ~/otelcol/config.yaml` 3. `echo 'some line' >> /var/log/busybox/refactroring_test.log` 4. ```console 2024-04-24T09:29:17.104+0300 info LogsExporter {"kind": "exporter", "data_type": "logs", "name": "debug", "resource logs": 1, "log records": 1} 2024-04-24T09:29:17.104+0300 info ResourceLog #0 Resource SchemaURL: ScopeLogs #0 ScopeLogs SchemaURL: InstrumentationScope LogRecord #0 ObservedTimestamp: 2024-04-24 06:29:17.005433317 +0000 UTC Timestamp: 1970-01-01 00:00:00 +0000 UTC SeverityText: SeverityNumber: Unspecified(0) Body: Str(some line) Attributes: -> extra: Str(my-val) -> log.file.name: Str(1.log) Trace ID: Span ID: Flags: 0 {"kind": "exporter", "data_type": "logs", "name": "debug"} ``` **Documentation:** <Describe the documentation added.> TBA. Signed-off-by: ChrsMark <[email protected]>
djaglowski
force-pushed
the
pkg-stanza-rm-sugared
branch
3 times, most recently
from
4bbbdf8 to
8b59da2
Compare
djaglowski
changed the title
djaglowski
force-pushed
the
pkg-stanza-rm-sugared
branch
from
8b59da2 to
6d3666e
Compare
djaglowski
force-pushed
the
pkg-stanza-rm-sugared
branch
2 times, most recently
from
4af70a1 to
74c9667
Compare
djaglowski
force-pushed
the
pkg-stanza-rm-sugared
branch
from
74c9667 to
e5d5060
Compare
djaglowski
force-pushed
the
pkg-stanza-rm-sugared
branch
from
e5d5060 to
9921a8e
Compare
|
This is just waiting on a review @open-telemetry/collector-contrib-approvers @ChrsMark |
mx-psi
reviewed
May 13, 2024
ChrsMark
reviewed
May 14, 2024
djaglowski
force-pushed
the
pkg-stanza-rm-sugared
branch
from
9921a8e to
d3733b1
Compare
djaglowski
force-pushed
the
pkg-stanza-rm-sugared
branch
from
d3733b1 to
06da547
Compare
mx-psi
approved these changes
May 16, 2024
dmitryax
added a commit
to signalfx/splunk-otel-collector
that referenced
this pull request
May 22, 2024
Remove usage of incorrect logger inherited from stanza InputOperator and removed in 0.101.0 as part of open-telemetry/opentelemetry-collector-contrib#32177
dmitryax
added a commit
to signalfx/splunk-otel-collector
that referenced
this pull request
May 22, 2024
Remove usage of incorrect logger inherited from stanza InputOperator and removed in 0.101.0 as part of open-telemetry/opentelemetry-collector-contrib#32177
|
This seems to have broken drop_quiet and send_quiet from what I can tell. Now my failed "move" operator is logging even though i have it on send_quiet |
@fordneild would you mind opening a separate issue for this? cc @djaglowski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#32662 updated many exported functions to accept
component.TelemetrySettingsinstead ofzap.SugaredLogger. This PR continues from there by passingcomponent.TelemetrySettingsdeeper into the inner packages, and migrates from usingzap.SugaredLoggerto instead usingzap.Logger(as provided bycomponent.TelemetrySettings).