Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][receiver/sqlserver] Add direct connection config options #32176

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

crobert-1
Copy link
Member

Description:

This adds config options for direct connection to a SQL server instance. For the sake of PR size, this adds no functionality, it's simply config options and validation.

Link to tracking Issue:
This was originally part of #31915, but I'm breaking this out to make the original PR a more manageable size.

#30297

Testing:
Existing tests and added tests are all passing.

Documentation:
No documentation on purpose. The added config options currently have no impact on functionality, so users shouldn't be aware of this, and shouldn't try to use them yet.

@crobert-1 crobert-1 requested a review from djaglowski as a code owner April 4, 2024 18:46
@crobert-1 crobert-1 requested a review from a team April 4, 2024 18:46
@crobert-1 crobert-1 added the Run Windows Enable running windows test on a PR label Apr 4, 2024
@github-actions github-actions bot requested a review from StefanKurek April 4, 2024 18:47
@crobert-1 crobert-1 force-pushed the sqlserver_config_updates branch from 503e64d to e23c18f Compare April 15, 2024 18:23
@djaglowski djaglowski merged commit a980e8e into open-telemetry:main Apr 16, 2024
178 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 16, 2024
@TigerC10
Copy link

Is Windows Auth supported?

@crobert-1
Copy link
Member Author

Is Windows Auth supported?

You're wondering if these configuration options are available on Windows? If so, yes they are.

@TigerC10
Copy link

Is Windows Auth supported?

You're wondering if these configuration options are available on Windows? If so, yes they are.

Not quite, I'm wondering if we can use windows authentication as opposed to username/password hardcoded in the config. We run the opentelemetry collector as a windows service, and as such there is a service account associated with the opentelemetry collector. We can grant the service account access to the database, and if Windows Authentication is supported then the collector could make a query without needing a username/password combo.

@crobert-1
Copy link
Member Author

I don't believe that's supported currently, but you're welcome to open an issue to request it 👍

@TigerC10
Copy link

I don't believe that's supported currently, but you're welcome to open an issue to request it 👍

😃 #32986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
receiver/sqlserver Run Windows Enable running windows test on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants