Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/opamp] Add config options to specify extra non-identifying attributes #32153

Conversation

BinaryFissionGames
Copy link
Contributor

Description:

  • Adds a new agent_description.non_identifying_attributes config option to allow setting user-defined non-identifying attributes

Link to tracking Issue: Closes #32107

Testing:
Added unit tests
Manually tested against an OpAMP server

Documentation:
Added new parameter to extension docs

@BinaryFissionGames BinaryFissionGames force-pushed the feat/opamp-extension-user-defined-attributes branch from 3e29ed6 to 2ba803f Compare April 3, 2024 19:10
@github-actions github-actions bot added the cmd/otelcontribcol otelcontribcol command label Apr 3, 2024
@BinaryFissionGames BinaryFissionGames marked this pull request as ready for review April 3, 2024 19:19
@BinaryFissionGames BinaryFissionGames requested a review from a team April 3, 2024 19:19
Copy link
Member

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple wording nits, functionality looks good to me 👍

extension/opampextension/README.md Outdated Show resolved Hide resolved
extension/opampextension/README.md Outdated Show resolved Hide resolved
Copy link
Member

@JaredTan95 JaredTan95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I happened to have this requirement, thank you for your tribute
LGTM

@BinaryFissionGames BinaryFissionGames force-pushed the feat/opamp-extension-user-defined-attributes branch from 756338c to 315f3dd Compare April 10, 2024 18:43
@djaglowski djaglowski merged commit c356157 into open-telemetry:main Apr 16, 2024
170 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[extension/opamp] Add support for user-specified non-identifying attributes
4 participants