[receiver/hostmetrics] Add cache_boot_time field to process scrapers #31998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the `cache_boot_time` config option to the `process` and `processes` scrapers. This allows an option for `gopsutil` functionality that will cache boot times after the first time they are fetched. It has a significant positive effect on the CPU usage of these scrapers.
braydonk
changed the title
dmitryax
reviewed
Mar 27, 2024
| @@ -13,4 +13,8 @@ type Config struct { | |||
| // MetricsBuilderConfig allows customizing scraped metrics/attributes representation. | |||
| metadata.MetricsBuilderConfig `mapstructure:",squash"` | |||
| internal.ScraperConfig | |||
|
|
|||
| // CacheBootTime enables caching of the boot time of the system and each process. This means the | |||
| // boot times will never be updated as long as the collector is running. | |||
There was a problem hiding this comment.
What are the downsides of enabling it? Should we consider enabling it without a config option?
|
Closing in favour of #32126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds the
cache_boot_timeconfig option to theprocessandprocessesscrapers. This allows an option forgopsutilfunctionality that will cache boot times after the first time they are fetched. It has a significant positive effect on the CPU usage of these scrapers.Link to tracking Issue:
#28849
Testing:
Tested a build of the collector with these fields on and off and took CPU profiles to check the difference and see that
common.BootTimeWithContextcalls disappear after the first scrape.Documentation:
TODO