[statsdreceiver] add obsreport metrics for accepted/refused count #31822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardproblems
force-pushed
the
feature-statsdreceiver-metrics
branch
2 times, most recently
from
04e895f to
f6e0622
Compare
hardproblems
force-pushed
the
feature-statsdreceiver-metrics
branch
from
d8f1202 to
991ff3b
Compare
|
@TylerHelmuth FYI see also a related PR #31839 |
gci write --skip-generated -s standard -s default .
hardproblems
force-pushed
the
feature-statsdreceiver-metrics
branch
2 times, most recently
from
66a1938 to
6d2cd3a
Compare
There was a problem hiding this comment.
@hardproblems have you run this locally and confirmed the new metrics appear as expected?
@TylerHelmuth actually no metrics appeared. I'm going to try ctx.Background() |
|
Make sure you send some data through, I don't believe |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add accepted/refused metrics to statsdreceiver
Link to tracking Issue:
#24278
Testing:
Documentation:
cc @jmacd @dmitryax