Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build from ForEach -> Range #3174

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Conversation

jrcamp
Copy link
Contributor

@jrcamp jrcamp commented Apr 19, 2021

No description provided.

@jrcamp jrcamp requested a review from a team April 19, 2021 21:30
@codecov
Copy link

codecov bot commented Apr 19, 2021

Codecov Report

Merging #3174 (0f90702) into main (7e9847e) will increase coverage by 0.10%.
The diff coverage is 98.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3174      +/-   ##
==========================================
+ Coverage   91.82%   91.92%   +0.10%     
==========================================
  Files         492      493       +1     
  Lines       23692    23932     +240     
==========================================
+ Hits        21755    22000     +245     
+ Misses       1432     1427       -5     
  Partials      505      505              
Flag Coverage Δ
integration 63.32% <ø> (ø)
unit 90.94% <98.51%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
exporter/newrelicexporter/newrelic.go 96.23% <95.62%> (+2.00%) ⬆️
exporter/newrelicexporter/config.go 100.00% <100.00%> (ø)
exporter/newrelicexporter/factory.go 100.00% <100.00%> (ø)
exporter/newrelicexporter/metrics.go 100.00% <100.00%> (ø)
exporter/newrelicexporter/transformer.go 100.00% <100.00%> (+4.37%) ⬆️
receiver/k8sclusterreceiver/watcher.go 95.29% <0.00%> (-2.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 765429a...0f90702. Read the comment docs.

@bogdandrutu bogdandrutu merged commit ed6facc into open-telemetry:main Apr 19, 2021
@jrcamp jrcamp deleted the fix-build branch April 19, 2021 23:20
pmatyjasek-sumo pushed a commit to pmatyjasek-sumo/opentelemetry-collector-contrib that referenced this pull request Apr 28, 2021
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.37.0 to 1.37.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.37.0...v1.37.1)

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants