[pkg/stanza/fileconsumer] Establish options pattern for Build #31596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djaglowski
force-pushed
the
pkg-stanza-fileconsumer-build-opts
branch
from
f2f080d to
64e398f
Compare
atoulme
approved these changes
Mar 6, 2024
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes a step towards modularizing the fileconsumer package. It's become increasingly clear that several different aspects of the package should support alternative implementations. For example, how to find and filter files, how to track them (fingerprints vs path vs none), how to interpret and tokenize, or how to trigger the overall behavior.
This PR takes a small step towards enabling that pattern by establishing an options pattern for building the fileconsumer.Manager. Future work can establish interfaces for alternative behaviors and allow them to be specified via options.
Supports #31534