[chore][exporter/signalfx] fix tests #31522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Mar 1, 2024
dmitryax
approved these changes
Mar 1, 2024
Comment on lines
+328
to
+330
| if tt.wantMetricCount == 0 { | ||
| assert.Equal(t, tt.wantMetrics(), gotMetrics) | ||
| } else { |
There was a problem hiding this comment.
I'd say this part is redundant. pmetrictest.CompareMetrics should do the job even if wantMetricCount == 0, right?
There was a problem hiding this comment.
with no histograms, we return uninitialized pmetric.Metrics{} and CompareMetrics does not check for nil
|
ci failure due to #31443 |
|
@jinja2 Can you update the description to say |
crobert-1
approved these changes
Mar 1, 2024
songy23
added
the
ready to merge
codeboten
approved these changes
Mar 1, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
Update test cases to ignore the order of resource/scope metrics since the returned histograms-only pmetrics can have different ordering for resource and scope metrics Fixes open-telemetry#31493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Update test cases to ignore the order of resource/scope metrics since the returned histograms-only pmetrics can have different ordering for resource and scope metrics
Link to tracking Issue: Fixes #31493
Testing:
Documentation: