Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/prometheusremotewrite] Hash labels using xxhash for performance #31385

Merged
merged 22 commits into from
Apr 12, 2024
Merged
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6094d5e
prometheusremotewrite: Hash labels using xxhash for performance
aknuds1 Feb 22, 2024
8010ed4
Apply reviewer feedback
aknuds1 Mar 7, 2024
b0d8e58
Fix PrometheusConverter.AddExemplars
aknuds1 Mar 7, 2024
9764fb7
Refactor
aknuds1 Mar 7, 2024
4cbf269
Refer to StableHash instead of Labels.Hash
aknuds1 Mar 7, 2024
b5065b9
Make FromMetrics a backwards compatible shim
aknuds1 Mar 13, 2024
2a9d9e6
Mark FromMetrics as deprecated
aknuds1 Mar 13, 2024
f035bef
Drop pluggable architecture
aknuds1 Mar 14, 2024
17bbcac
Merge remote-tracking branch 'open-telemetry/main' into arve/xxhash
aknuds1 Mar 14, 2024
89eb8eb
Merge remote-tracking branch 'open-telemetry/main' into arve/xxhash
aknuds1 Mar 17, 2024
c156752
Construct time series slice in benchmark
aknuds1 Mar 17, 2024
22fac83
Merge remote-tracking branch 'open-telemetry/main' into arve/xxhash
aknuds1 Mar 28, 2024
23514c6
Benchmark FromMetrics and PrometheusConverter.FromMetrics separately
aknuds1 Mar 28, 2024
e45aed9
timeSeriesSignature: Add test case for fast path
aknuds1 Mar 28, 2024
6ab5bef
Add unit tests for PrometheusConverter.getOrCreateTimeSeries
aknuds1 Mar 28, 2024
b72d63f
Merge remote-tracking branch 'open-telemetry/main' into arve/xxhash
aknuds1 Mar 28, 2024
8916ad8
Merge remote-tracking branch 'open-telemetry/main' into arve/xxhash
aknuds1 Mar 28, 2024
6d4a95a
Merge remote-tracking branch 'open-telemetry/main' into arve/xxhash
aknuds1 Apr 11, 2024
0f2d697
Remove new API
aknuds1 Apr 11, 2024
50ce761
Update pkg/translator/prometheusremotewrite/metrics_to_prw.go
aknuds1 Apr 11, 2024
c9364bd
Update pkg/translator/prometheusremotewrite/metrics_to_prw.go
aknuds1 Apr 11, 2024
35774ad
Fix build
aknuds1 Apr 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .chloggen/arve_xxhash.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# Use this changelog template to create an entry for release notes.

# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. filelogreceiver)
component: prometheusremotewrite

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Optimize the prometheusremotewrite.FromMetrics function, based around more performant metric identifier hashing.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [31385]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:

# If your change doesn't affect end users or the exported elements of any package,
# you should instead start your pull request title with [chore] or use the "Skip Changelog" label.
# Optional: The change log or logs in which this entry should be included.
# e.g. '[user]' or '[user, api]'
# Include 'user' if the change is relevant to end users.
# Include 'api' if there is a change to a library API.
# Default: '[user]'
change_logs: [api]
1 change: 1 addition & 0 deletions pkg/translator/prometheusremotewrite/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ module github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/
go 1.21

require (
github.com/cespare/xxhash/v2 v2.3.0
github.com/open-telemetry/opentelemetry-collector-contrib/internal/coreinternal v0.98.0
github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/prometheus v0.98.0
github.com/prometheus/common v0.52.2
Expand Down
2 changes: 2 additions & 0 deletions pkg/translator/prometheusremotewrite/go.sum

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading