[pkg/stanza] Update KeyValue parser to use parseutils pkg #31291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaasman00
commented
Feb 16, 2024
djaglowski
approved these changes
Feb 16, 2024
6 tasks
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…etry#31291) **Description:** <Describe what has changed.> Updates the KeyValue parser to use the parseutils pkg and subsequent functions **Link to tracking Issue:** N/A Follows up on this [comment](open-telemetry#31035 (comment)) about merging functionality between Stanza and OTTL key value parsing **Testing:** Unit tests still pass, had to update one because of different wording in err message **Documentation:** N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updates the KeyValue parser to use the parseutils pkg and subsequent functions
Link to tracking Issue: N/A
Follows up on this comment about merging functionality between Stanza and OTTL key value parsing
Testing:
Unit tests still pass, had to update one because of different wording in err message
Documentation: N/A